python3Packages.trustme: skip disallowed w+x test on aarch64-darwin #115226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
Member
|
/rebase staging |
SuperSandro2000
requested changes
Mar 6, 2021
github-actions
bot
force-pushed
the
ivan/trustme-wx
branch
from
516fd74 to
de3605b
Compare
Contributor
|
Rebased, please reopen the pull request to restart CI |
ofborg
bot
added
10.rebuild-darwin: 5001+
Member
|
Git is broken on staging so I can't test this change. |
Contributor
Author
|
Staging should be good now. It would be nice to merge this. |
21 tasks
Member
|
Is this only a test failure, or does the underlying pyOpenSSL issue make this package non-functional? |
Contributor
Author
|
Some parts of pyOpenSSL are indeed broken: pyca/pyopenssl#873. I don't think that the entirety of it is broken, since there are basic functions in there that don't require callbacks. |
ofborg
bot
added
10.rebuild-darwin: 501-1000
ofborg
bot
removed
10.rebuild-darwin: 5001+
Contributor
Author
|
Rebased, hopefully this can be merged now. |
11 tasks
dbaynard
added a commit
to dbaynard/nixpkgs
that referenced
this pull request
Nov 11, 2022
As indicated in NixOS#175875, `pyopenssl` does not support aarch64-darwin. In NixOS#115226, the only test that required `pyopenssl` was disabled on `aarch64-darwin` — but unfortunately the package doesn’t build. This commit makes two changes. 1. The `pyopenssl` dependency is no longer pulled in on `aarch64-darwin`. The derivation is no longer marked broken. 2. The test suite is patched so that `OpenSSL.SSL` is no longer imported; this was only used by the disabled test. As a result the test suite runs (and succeeds).
13 tasks
dbaynard
added a commit
to dbaynard/nixpkgs
that referenced
this pull request
Nov 16, 2022
As indicated in NixOS#175875, `pyopenssl` does not support aarch64-darwin. In NixOS#115226, the only test that required `pyopenssl` was disabled on `aarch64-darwin` — but unfortunately the package doesn’t build. This commit makes two changes. 1. The `pyopenssl` dependency is no longer pulled in on `aarch64-darwin`. The derivation is no longer marked broken. 2. The test suite is patched so that `OpenSSL.SSL` is no longer imported; this was only used by the disabled test. As a result the test suite runs (and succeeds).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Another one to help #105026.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)